Product Form Abstraction #1027
Merged
Product Form Abstraction #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/Shopify/hydrogen/pull/1027/files#diff-8b58d224aa70a8818cc53be7f43fff8838e38a1d87672f2fb14f9263ae3b1b23 |
templates/demo-store/app/routes/($locale).products.$productHandle.tsx
Outdated
Show resolved
Hide resolved
| @@ -220,10 +211,103 @@ export function ProductForm() { | |||
| return ( | |||
| <div className="grid gap-10"> | |||
| <div className="grid gap-4"> | |||
| <ProductOptions | |||
| <VariantSelector | |||
| options={product.options} | |||
There was a problem hiding this comment.
Do we need options and variants separated out? Shouldn't we just have product={product} and we just derive options and variants from that?
There was a problem hiding this comment.
I like having them separate, so that they can come from separate requests. Only options is required. The variants could be deferred.
|
Also left comments on the proposal: https://gist.github.com/blittle/d9205d4ac72528005dc6f3104c328ecd?permalink_comment_id=4607765#gistcomment-4607765 |
This comment has been minimized.
This comment has been minimized.
Closed
juanpprieto
pushed a commit
that referenced
this pull request
Jul 10, 2023
* Product form implementation Shopify/hydrogen-internal#23
Merged
FrcPpe
pushed a commit
to FrcPpe/hydrogen
that referenced
this pull request
Aug 13, 2023
* Product form implementation https://github.com/Shopify/hydrogen-internal/issues/23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Implements: https://github.com/Shopify/hydrogen-internal/issues/23
See https://gist.github.com/blittle/d9205d4ac72528005dc6f3104c328ecd for a public explanation.
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist
Docs WIP: https://shopify-dev.shopify-dev-4mgc.bret-little.us.spin.dev/docs/api/hydrogen/2023-04/unstable/components/variantselector