Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file copy filter #1144

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Fix file copy filter #1144

merged 3 commits into from
Jul 25, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 25, 2023 •
edited
Loading

The absolute path used in the filter could contain dist or node_modules before the template directory. Using a relative path should fix the issue.

@frandiox frandiox requested a review from a team July 25, 2023 09:29
@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@frandiox frandiox merged commit b8898f0 into 2023-04 Jul 25, 2023
10 checks passed
@frandiox frandiox deleted the fd-init-fix branch July 25, 2023 12:12
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@frandiox @FrcPpe
Fix file copy filter (Shopify#1144)
ce9d747 
* Fix file copy filter

* Use relative paths in filter

* Oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@frandiox