Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom product paths to the VaraiantSelector component #1271

Merged
merged 3 commits into from Aug 25, 2023
Merged

Add custom product paths to the VaraiantSelector component #1271

merged 3 commits into from Aug 25, 2023

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Aug 24, 2023

WHY are these changes introduced?

Add custom product paths to the VariantSelector component:

<VariantSelector handle="snowboard" productPath="shop" options={options}>
  {/* ... */}
</VariantSelector>

Fixes #1262

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

frandiox
frandiox reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Just left a comment.

packages/hydrogen/src/product/VariantSelector.ts Show resolved Hide resolved
@blittle blittle merged commit 17892a7 into main Aug 25, 2023
10 checks passed
@blittle blittle deleted the bl-path-variant-selector branch August 25, 2023 15:09
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blittle @frandiox