Make the CLI bundle analysis compatible with older Remix versions that don't output a metafile #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t don't output a metafile
blittle
commented
Sep 21, 2023
| @@ -66,7 +75,7 @@ export async function getBundleAnalysisSummary(bundlePath: string) { | |||
| .split('\n') | |||
| .filter((line) => { | |||
| const match = line.match( | |||
| /(.*)\/node_modules\/(react-dom|@remix-run|@shopify\/hydrogen|react-router|react-router-dom)\/(.*)/g, | |||
| /(.*)(node_modules\/|server-assets-manifest:|server-entry-module:)(react-dom|@remix-run|@shopify\/hydrogen|react-router|react-router-dom)\/(.*)/g, | |||
There was a problem hiding this comment.
An unrelated fix to the Regular expression hiding in the bundle summary Remix/React and other dependencies that are always present.
blittle
commented
Sep 21, 2023
| sizeMB: number, | ||
| bundleStats: boolean, | ||
| remixConfig: RemixConfig, | ||
| ) { |
There was a problem hiding this comment.
All the bundle analysis logic is moved in here, and only executed if the metafile exists
blittle
commented
Sep 21, 2023
| buildPathWorkerFile: string, | ||
| sizeMB: number, | ||
| remixConfig: RemixConfig, | ||
| ) { |
There was a problem hiding this comment.
If it doesn't exist, output this simple status, which is essentially what the CLI did prior to the new bundle analytics.
juanpprieto
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist