Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storefrontRedirect and discount redirects #1399

Merged
merged 4 commits into from Oct 10, 2023
Merged

Fix storefrontRedirect and discount redirects #1399

merged 4 commits into from Oct 10, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Oct 5, 2023

Redirects were not correctly filtering out all possible absolute URLs. I've added some unit tests with different cases.

@frandiox frandiox requested review from blittle, juanpprieto and a team October 5, 2023 10:33
juanpprieto
juanpprieto approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@benjaminsehl benjaminsehl merged commit 4156d16 into main Oct 10, 2023
10 checks passed
@benjaminsehl benjaminsehl deleted the fd-fix-absolute-redirect branch October 10, 2023 15:20
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpprieto juanpprieto juanpprieto approved these changes

@blittle blittle Awaiting requested review from blittle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frandiox @juanpprieto @benjaminsehl