Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move createCartHandler's customMethods__unstable to stable #1440

Merged
merged 8 commits into from Oct 25, 2023
Merged

Move createCartHandler's customMethods__unstable to stable #1440

merged 8 commits into from Oct 25, 2023

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Oct 20, 2023 •
edited

WHY are these changes introduced?

Move createCartHandler's customMethods__unstable to stable

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@wizardlyhel
Copy link
Contributor Author

wizardlyhel commented Oct 20, 2023 •
edited

@frandiox Would you check the --codegen-unstable changes.

@wizardlyhel wizardlyhel mentioned this pull request Oct 20, 2023
Merged
12 tasks
@wizardlyhel
Copy link
Contributor Author

Oops! I didn't know you had a codegen stable PR. I'll remove it from this PR.

@wizardlyhel wizardlyhel changed the title Move unstable to stable Move createCartHandler's customMethods__unstable to stable Oct 20, 2023
@wizardlyhel @frandiox
Update packages/hydrogen/src/product/VariantSelector.test.ts
9391709 
Co-authored-by: Fran Dios <frankdiox@gmail.com>
Base automatically changed from 2023-10 to main October 25, 2023 21:34
@wizardlyhel wizardlyhel merged commit f24e342 into main Oct 25, 2023
9 checks passed
@wizardlyhel wizardlyhel deleted the sfapi-2023-10-stable-apis branch October 25, 2023 22:31
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
2023-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wizardlyhel @frandiox