bump oxygen-cli, cli and cli-kit #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentezw
force-pushed
the
vez/bump-oxygencli
branch
from
b05e066
to
e2a56e2
Compare
frandiox
approved these changes
Nov 13, 2023
.changeset/thick-feet-behave.md
Outdated
| '@shopify/cli-hydrogen': patch | ||
| --- | ||
|
|
||
| bump @shopify/oxygen-cli from 2.3.2 to 2.6.1 |
There was a problem hiding this comment.
I think this might be confusing for users since they are not aware of any "oxygen cli". Instead of bumping a dependency, can you mention what is this PR actually fixing? Let's write changelogs for the users, we can always check commits/PRs if we devs need references 👍
packages/cli/package.json
Outdated
| "@shopify/hydrogen-codegen": "^0.1.0", | ||
| "@shopify/mini-oxygen": "^2.2.3", | ||
| "@shopify/oxygen-cli": "^2.3.2", | ||
| "@shopify/oxygen-cli": "^2.6.1", |
There was a problem hiding this comment.
Should we pin this dependency without the ^? I think oxygen-cli has automatic bumps and that might mean cli-kit gets out of sync, which is problematic sometimes. For example, the last bump to 3.50 caused a weird issue in the init flow (that one was an intentional bump, but I guess it could happen without us noticing).
vincentezw
force-pushed
the
vez/bump-oxygencli
branch
from
e2a56e2
to
e3edbc1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves an issue with the deployment verification check
WHAT is this pull request doing?
bumps
@shopify/oxygen-clito the most recent version 2.6.1. This resolves an issue with the deployment verification step in thedeploycommand. Bumps@shopify/cliand@shopify/cli-kitfrom 3.50.0 to 3.50.2.Added bonus is that the version of
oclif/corein this version ofoxygen-climatches the one used inhydrogen-cli.Checklist