Fix the <Seo /> component to render canonical URLs without trailing slashes #1622
Conversation
| @@ -411,15 +411,16 @@ export function generateSeoTags< | |||
| } | |||
|
|
|||
| const urlWithoutParams = content.split('?')[0]; | |||
There was a problem hiding this comment.
I didn't realize that our Seo implementation strips off all query parameters. Technically I don't think this is always the right thing to do. Would merchants ever want product variants to be indexed separately? The challenge to properly do this is we would need to know which query params relate to product options, and which are irrelevant and should be stripped 🤔
There was a problem hiding this comment.
At least from reading the SEO recommendations, it is not recommended to have query params, especially when the content is similar. For example,
search pages /search should be the main crawl-able page while other variants should have canonical url to the same search url
/search?query=blue- canonical url should be/search
Same should be with product variants - main url /products/best-product-ever. Its variants /products/best-product-ever?color=blue should have the same canonical urls because
- Majority of the page content is the same
- When grouped as the same canonical url, the product search ranking won't be fragmented by the variants
WHY are these changes introduced?
Fixes #1619. Thank you @joshuafredrickson!
WHAT is this pull request doing?
We change the Seo component so that it always strips the trailing slash. Are there scenarios where this is not desirable?
HOW to test your changes?
Load the demo store, and view the source code of http://localhost:3000/collections/freestyle/ and verify that the trailing slash is not included in the canonical URL tag.
Checklist