Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant option color on product page in demo store #1735

Conversation

SergeyAsadchiy
Copy link

WHY are these changes introduced?

This adds the usual functionality common to e-commerce

WHAT is this pull request doing?

This implementation allows the user to see the colour of the product variants and select the product of the desired colour

изображение

  • Clicking on a coloured square will take you to the page of the selected product variant.
  • The selected colour variant is highlighted with a frame
  • Unavailable colour variant is crossed out with a diagonal line.

HOW to test your changes?

  • Go to a page of product that has several colour variants
  • Here you will see squares with the colours of the product variants.
  • Click on a colour you want to go to the page of the selected product variant.
  • Chek selected and unavailabled pvoduct variants
  • Check with browser dark theme

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@SergeyAsadchiy
Copy link
Author

I've signed the CLA!

2 similar comments
@SergeyAsadchiy
Copy link
Author

I've signed the CLA!

@SergeyAsadchiy
Copy link
Author

I've signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant