Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ngrok flag to dev #1780

Closed
wants to merge 1 commit into from
Closed

Add ngrok flag to dev #1780

wants to merge 1 commit into from

Conversation

michenly
Copy link
Contributor

WHY are these changes introduced?

This PR is intended to make development easier by adding a ngrok flag to shopify hydrogen dev

WHAT is this pull request doing?

HOW to test your changes?

Test by using changing dev script to run shopify hydrogen dev --codegen --ngrok --ngrok-auth-token=<your-ngrok-auth-token> --ngrok-domain=<your-ngrok-domain>

or using shopify hydrogen dev --codegen --ngrok with two environment variables in .env file

in .env

NGROK_AUTHTOKEN=<your-ngrok-auth-token>
NGROK_DOMAIN=<your-ngrok-domain>

Next

  • add ngrok domain to CSP automatically
  • taking the ngrok url and changing them in admin using an API? (does this exist?)

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@michenly michenly self-assigned this Feb 20, 2024
@michenly michenly closed this Feb 21, 2024
@michenly michenly deleted the mc-add-ngrok-to-dev branch March 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant