Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ui_locale to be pass to login page #1842

Merged
merged 7 commits into from Mar 13, 2024
Merged

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Mar 12, 2024

WHY are these changes introduced?

Fixes #1835

WHAT is this pull request doing?

Allow locale to be passed to customer account login page

HOW to test your changes?

  1. Update account_.login.tsx with

    export async function loader({request, context}: LoaderFunctionArgs) {
      return context.customerAccount.login({uiLocales: 'JA'});
    }
  2. Locally run your project and go to sign n page

Expected: You should see the login interface in Japanese.

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

This comment has been minimized.

Copy link
Contributor

shopify bot commented Mar 12, 2024

Oxygen deployed a preview of your hl-pass-language-to-caapi branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment March 13, 2024 6:34 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel merged commit d007b7b into main Mar 13, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-pass-language-to-caapi branch March 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer Account API not passing locale via "ui_locales" parameter
2 participants