Update Miniflare and workerd dependencies #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frandiox
commented
Mar 18, 2024
| @@ -890,7 +890,7 @@ | |||
| "isOptional": true | |||
| } | |||
| ], | |||
| "value": "interface ExternalVideoBaseProps {\n /**\n * An object with fields that correspond to the Storefront API's [ExternalVideo object](https://shopify.dev/api/storefront/reference/products/externalvideo).\n */\n data: PartialDeep<ExternalVideoType, {recurseIntoArrays: true}>;\n /** An object containing the options available for either\n * [YouTube](https://developers.google.com/youtube/player_parameters#Parameters) or\n * [Vimeo](https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Using-Player-Parameters).\n */\n options?: YouTube | Vimeo;\n}" | |||
| "value": "export interface ExternalVideoBaseProps {\n /**\n * An object with fields that correspond to the Storefront API's [ExternalVideo object](https://shopify.dev/api/storefront/reference/products/externalvideo).\n */\n data: PartialDeep<ExternalVideoType, {recurseIntoArrays: true}>;\n /** An object containing the options available for either\n * [YouTube](https://developers.google.com/youtube/player_parameters#Parameters) or\n * [Vimeo](https://vimeo.zendesk.com/hc/en-us/articles/360001494447-Using-Player-Parameters).\n */\n options?: YouTube | Vimeo;\n}" | |||
There was a problem hiding this comment.
Is anyone familiar with the generated docs here? These changes add export to some of the internal interfaces/types and I'm not 100% this is fine with the docs 馃
There was a problem hiding this comment.
It's fine. It looks like part of type doc generation.
wizardlyhel
approved these changes
Mar 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1833
There's a change in Node 21.7.0 that makes Miniflare throw. This has been fixed upstream so we just need to update the dependency.
馃帺 :
main,nvm install 21.7npm run devin skeleton template, you'll see:While I was updating this dep, I fixed other inconsistencies with our dependencies (multipass example was using old Oxygen worker types) and deduped the package-lock. As a result, I think we are now using a newer version of TS for development and a few type issues came up. I've fixed those as well by refactoring a bit hydrogen-react and hydrogen.