Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session type after changing Customer Account client #1869

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

frandiox
Copy link
Contributor

When updating to the Customer Account API in 1820241, we removed the types returned by the session object.
I've changed a few things here to make it work again in TS and JS types (with JSDoc).

image

@frandiox frandiox requested review from michenly and a team March 19, 2024 13:51
Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks kinda funny you need to define empty objects after the extends, but make sense 👍

@michenly
Copy link
Contributor

also reminder that this likely need to make it to demo-store

@frandiox frandiox merged commit 7625623 into main Mar 21, 2024
12 of 13 checks passed
@frandiox frandiox deleted the fd-fix-customer-account-types branch March 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants