Improve logs in Vite dev server #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
approved these changes
Mar 29, 2024
| @@ -101,6 +103,7 @@ export function muteDevLogs({workerReload}: {workerReload?: boolean} = {}) { | |||
| injectLogReplacer('log'); | |||
| injectLogReplacer('error'); | |||
| injectLogReplacer('warn', warningDebouncer); | |||
| injectLogReplacer('debug', false); | |||
There was a problem hiding this comment.
This just essentially makes all console.debug() messages not show up?
There was a problem hiding this comment.
It adds a hook to console.debug. Then, if it matches any of our replacers, it modifies the message or suppresses it. The false is just to avoid the debouncing logic.
| [ | ||
| // Log that gets entangled with our initial dev logs | ||
| ([first]) => | ||
| typeof first === 'string' && |
There was a problem hiding this comment.
I know we want to keep the logs clean, but does it ever concern you just how much we monkey console.log and family?
There was a problem hiding this comment.
Ah, I see this other PR: #1928
This makes me much more comfortable.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Logs in Vite dev server are quite chaotic at the moment.
WHAT is this pull request doing?
HOW to test your changes?
It's easier to review this PR looking at each commit individually.
To test: run the development server in skeleton and Vite projects.