Create H2 Shopify/Cli plugin #194
Conversation
cartogram
force-pushed
the
cli-plugin
branch
from
29aaf12
to
4748532
Compare
There was a problem hiding this comment.
I think it's a good idea to align on the shopify cli with oclif. I think part of the issues we are having with ESM is none of our packages are compiling. Everything expects to run in ts-node. I think we need to convert each of the packages to actually compile an output, and properly define an exports property within each package.json. Ideally we shouldn't use tsc for that compilation.
I pulled this down and ran it locally. I can't get anything to build or run. Work in progress I assume?
| "sourceMap": true, | ||
| "inlineSources": true, | ||
| "noUncheckedIndexedAccess": true, | ||
| "outDir": "dist", |
There was a problem hiding this comment.
I wish we wouldn't use tsc for compiling :(
There was a problem hiding this comment.
Yup, I just did this temporarily because @frandiox has been working on this separately.
|
@blittle moving this back to draft until I can sort out the CI errors and wait until the turpo repo stuff merges. |
|
I think the CI errors here are similar to what I'm getting in #199 |
This PR converts the CLI into a oclif plugin for the Shopify CLI. I had to do some magic with a post-install script and convert the CLI to ESM.
We will need to change the way that the CLI is run in the demo store and tests. Related to #199 @frandiox interested in your thoughts here.