-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickstart CLI reference, expose routes
flag
#2009
Conversation
We detected some changes in |
@@ -56,7 +56,6 @@ export default class Init extends Command { | |||
routes: Flags.boolean({ | |||
description: 'Generate routes for all pages.', | |||
env: 'SHOPIFY_HYDROGEN_FLAG_ROUTES', | |||
hidden: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was hidden because nobody asked for it. I added it for my own testing but didn't double check on flag name, etc. But I think it's OK 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, in this case I'd like to make it public so that what's happening under the hood with --quickstart
is documented.
You'll need to run |
Hide styling flag revert hiding styling flag, handled elsewhere
5f25b4c
to
af616cf
Compare
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This PR does three things:
--quickstart
description. This was previously handled in plain markdown in the docs but with the new reference generated by the manifest it needs to be directly in the codebase;--routes
flag forinit
. Not clear to me why it was hidden in the first place;--styling
flag, which is no longer supported.