Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example usage of withCache #2020

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix example usage of withCache #2020

merged 2 commits into from
Apr 19, 2024

Conversation

frandiox
Copy link
Contributor

It wasn't passing request parameter so the Subrequest Profiler couldn't match it with its parent request.

@frandiox frandiox requested a review from a team April 19, 2024 12:29
Copy link
Contributor

shopify bot commented Apr 19, 2024

Oxygen deployed a preview of your fd-fix-example-withcache branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:30 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:30 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:30 PM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:30 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:30 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 19, 202412:31 PM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox merged commit 48218c3 into main Apr 19, 2024
14 checks passed
@frandiox frandiox deleted the fd-fix-example-withcache branch April 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants