Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Override react version to ^18.3.1 #2049

Closed

Conversation

RcKeller
Copy link

WHY are these changes introduced?

Fixes #2040

The issue is a blocker for all users attempting to create a new Hydrogen project, both by the cli and skeleton project.

WHAT is this pull request doing?

This hotfix bumps the version of react to the one @shopify/cli-kit is using. It is a non-breaking change for Hydrogen and a suitable hotfix to unblock users while core resolves the issues with CLI.

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@RcKeller
Copy link
Author

I have signed the CLA!

@frandiox
Copy link
Contributor

Hey 👋 Thanks for the PR.
The main issue we're seeing is that @shopify/cli pins the version to 18.2.0. Therefore, our desired fix would be changing that package instead so that we don't force existing users to update to 18.3.1.
The issue is reported here: Shopify/cli#3800

I think in the meantime users should use NPM resolutions to pin React to 18.2.0 🤔

@HeisUser
Copy link

How to override to latest react version? My system is MacOS.

@frandiox
Copy link
Contributor

frandiox commented May 1, 2024

Closing this since it is now fixed in the latest version 👍

@frandiox frandiox closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React version mismatch when creating new projects
3 participants