Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content-security-policy-builder version #2057

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

frandiox
Copy link
Contributor

This dependecy now has an ESM version so we don't need to preprocess it with Vite anymore.

@frandiox frandiox requested review from blittle and a team April 30, 2024 08:49
Copy link
Contributor

shopify bot commented Apr 30, 2024

Oxygen deployed a preview of your fd-update-esm-dep branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 30, 2024 8:49 AM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 30, 2024 8:49 AM
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 30, 2024 8:49 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 30, 2024 8:49 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 30, 2024 8:49 AM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment May 1, 202411:06 PM

Learn more about Hydrogen's GitHub integration.

'@shopify/hydrogen': patch
---

Update `content-security-policy-builder` subdependency to ESM version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO these comments should get stripped out in the final release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but we need the changeset to ensure at least we release the package :/

@frandiox frandiox merged commit 17528db into main May 2, 2024
13 checks passed
@frandiox frandiox deleted the fd-update-esm-dep branch May 2, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants