Add missing undici dependency
#2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
reviewed
May 1, 2024
Comment on lines
+298
to
300
| response.body.pipe(nodeResponse); | ||
| } | ||
|
|
||
| return response.body.pipe(nodeResponse); | ||
| }) |
There was a problem hiding this comment.
Does it matter that this doesn't return anymore?
There was a problem hiding this comment.
No, we were not using the returned value.
blittle
approved these changes
May 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
undicifor the devtools but forgot to add it to dependencies. It generally works because it is added byminiflarebut I've seen some situations reported where it cannot find the dependency.I've tried to remove it and use
node:httpsinstead but found issues, probably related to https://github.com/orgs/nodejs/discussions/49734The version of
undiciadded to our dependencies is the same Miniflare uses to avoid adding duplicates.To 馃帺 this, simply run the skeleton with
npm run dev -- --debugand open the devtools. It should work without errors.