Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup getSelectedProductOptions implementation and add JSDocs #2089

Merged
merged 3 commits into from
May 8, 2024
Merged

Cleanup getSelectedProductOptions implementation and add JSDocs #2089

merged 3 commits into from
May 8, 2024

Conversation

juanpprieto
Copy link
Contributor

Removes the no longer necessary .filter from getSelectedProductOptions product loader implementation

Ignores irrelevant params

productSelector.mp4

Added JSDoc hint for getSelectedProductOptions

Screenshot 2024-05-07 at 11 41 00 AM

@juanpprieto juanpprieto requested a review from a team May 7, 2024 18:44
frandiox
frandiox approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benjaminsehl
benjaminsehl approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@benjaminsehl benjaminsehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!

@juanpprieto juanpprieto merged commit 6f5061d into main May 8, 2024
13 checks passed
@juanpprieto juanpprieto deleted the juanpprieto/t branch May 8, 2024 15:54
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminsehl benjaminsehl benjaminsehl approved these changes

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanpprieto @benjaminsehl @frandiox