Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] release 2024-04 #2213

Closed
wants to merge 1 commit into from

Conversation

shopify-github-actions-access[bot]
Copy link
Contributor

@shopify-github-actions-access shopify-github-actions-access bot commented Jun 6, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@shopify/create-hydrogen@5.0.0

Major Changes

  • The code is now bundled to enhance installation speed. (#2184) by @frandiox

@shopify/cli-hydrogen@8.1.1

Patch Changes

  • Fix CLI upgrade notification when running from a globla process. (#2184) by @frandiox

  • skeleton template was updated to do session commit in server call instead of routes (#2137) by @michenly

  • Remove PUBLIC_STORE_DOMAIN environment variable from .env when creating new projects with mock.shop. (#2221) by @frandiox

  • Added an --auth-bypass-token-duration flag to the deploy command to allow for specified token duration between 1 to 12 hours. (#2182) by @NelsonLee-Code

@shopify/hydrogen@2024.4.4

Patch Changes

  • customerAccount no longer commit session automatically in any situation. (#2137) by @michenly

skeleton@2024.4.6

Patch Changes

  • Remove manual setting of session in headers and recommend setting it in server after response is created. (#2137) by @michenly

    Step 1: Add isPending implementation in session

    // in app/lib/session.ts
    export class AppSession implements HydrogenSession {
    +  public isPending = false;
    
      get unset() {
    +    this.isPending = true;
        return this.#session.unset;
      }
    
      get set() {
    +    this.isPending = true;
        return this.#session.set;
      }
    
      commit() {
    +    this.isPending = false;
        return this.#sessionStorage.commitSession(this.#session);
      }
    }

    Step 2: update response header if session.isPending is true

    // in server.ts
    export default {
      async fetch(request: Request): Promise<Response> {
        try {
          const response = await handleRequest(request);
    
    +      if (session.isPending) {
    +        response.headers.set('Set-Cookie', await session.commit());
    +      }
    
          return response;
        } catch (error) {
          ...
        }
      },
    };

    Step 3: remove setting cookie with session.commit() in routes

    // in route files
    export async function loader({context}: LoaderFunctionArgs) {
      return json({},
    -    {
    -      headers: {
    -        'Set-Cookie': await context.session.commit(),
    -      },
        },
      );
    }
  • Updated dependencies [4337200c, 10a419bf, 4337200c, 9eb60d73, 83cb96f4]:

    • @shopify/hydrogen@2024.4.4
    • @shopify/cli-hydrogen@8.1.1

Copy link
Contributor

shopify bot commented Jun 6, 2024

Oxygen deployed a preview of your changeset-release/main branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 6, 2024 6:47 PM

Learn more about Hydrogen's GitHub integration.

@github-actions github-actions bot force-pushed the changeset-release/main branch 5 times, most recently from 5ddb19e to b5e871a Compare June 11, 2024 15:58
@wizardlyhel
Copy link
Contributor

These changes will be part of 2024-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant