Fix typo and expand getSeoMeta doc example #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `matches` is an array, the TS example treats it as an object The upgrade docs included a more robust example of spreading all the seo config, adding here as well
dvnrsn
force-pushed
the
meta-getSeoMeta-example
branch
from
b7315d0
to
591f1b4
Compare
|
blittle
reviewed
Jun 20, 2024
blittle
approved these changes
Jun 20, 2024
blittle
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There is a typo in docs
While
matchesis an array, the TS example treats it as an objectThe upgrade docs included a more robust example of spreading all the seo config, adding here as well
hydrogen/packages/hydrogen/CHANGELOG.md
Line 296 in 4337200