Update @shopify/oxygen-workers-types to v4.1.2
#2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michenly
commented
Jun 14, 2024
michenly
commented
Jun 14, 2024
frandiox
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
@michenly Thanks! I've made a few changes:
- Updated
hydrogen-codegen,cli-hydrogenandhydrogento avoid depending on workers types since these packages should be agnostic.- Sometimes we rely on workers types for things like doc examples. For this, we use a local
dev.env.d.tswith worker type mocks.
- Sometimes we rely on workers types for things like doc examples. For this, we use a local
- Updated the changeset with the things that actually change (e.g. bumping a devDependency shouldn't need a changeset/release).
- I found related type issues and also fixed them.
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
frandiox
requested changes
Jun 17, 2024
There was a problem hiding this comment.
While working on fixing these issues I noticed there's a problem in oxygen-workers-types. I've opened a PR and we should probably wait for that before releasing this change: https://github.com/Shopify/oxygen-workers-types/pull/228
frandiox
changed the title
@shopify/oxygen-workers-types to v4.1.1@shopify/oxygen-workers-types to v4.1.2
frandiox
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2126