Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init command in monorepo #2305

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix init command in monorepo #2305

merged 1 commit into from
Jul 10, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 8, 2024

Sometimes when creating new projects with h2 init in our monorepo, there's an NPM 401 error during dep intallation. This PR copies .npmrc to the new project in the monorepo to workaround this issue.

Aside from that, when choosing not to install dependencies it will do an automatic symlink to the monorepo node_modules, just like we do during testing. This is useful to create projects to test things quickly without installing deps.

@frandiox frandiox requested a review from a team July 8, 2024 07:06
Copy link
Contributor

github-actions bot commented Jul 8, 2024

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Jul 8, 2024

Oxygen deployed a preview of your fd-fix-monorepo-init branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 7:07 AM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully. This will make testing much easer. Thank you.

@michenly michenly merged commit 76e9285 into main Jul 10, 2024
13 checks passed
@michenly michenly deleted the fd-fix-monorepo-init branch July 10, 2024 19:48
michenly pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants