update template client entry to match remix #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
approved these changes
Mar 2, 2023
frandiox
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Since you are updating the entries, can you also update the entry.server.tsx with this? https://github.com/remix-run/remix/blob/a7661fc3228a0f34e9d9953938cc4bdbcaaf52b1/packages/remix-dev/config/defaults/entry.server.cloudflare.tsx
They've added better error handling there.
These files are now optional if we were deploying to Cloudflare or Deno. I don't think they can detect Oxygen yet, though.
|
@frandiox thanks for the tip. I updated it as well. cc @cartogram @juanpprieto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable time-slicing with
React.startTransitionto prevent hydration from blocking the main thread for too long for those users who immediately scroll.Based on Remix templates