Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode characters in sitemap.xml #662

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Encode characters in sitemap.xml #662

merged 3 commits into from
Mar 10, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Mar 8, 2023

WHY are these changes introduced?

Fixes #613

Certain characters break XML, such as & or <.

WHAT is this pull request doing?

Escape problematic characters in XML.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@frandiox frandiox requested a review from a team March 8, 2023 10:18
@frandiox frandiox mentioned this pull request Mar 8, 2023
Closed
@frandiox frandiox merged commit 84e3578 into 2023-01 Mar 10, 2023
@frandiox frandiox deleted the fd-xml-encode branch March 10, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartogram cartogram cartogram approved these changes

@juanpprieto juanpprieto juanpprieto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on sitemap.xml for demo
3 participants
@frandiox @cartogram @juanpprieto