Update Hydrogen CLI to use latest cli-kit prompts #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
frehner
reviewed
Mar 29, 2023
graygilmore
reviewed
Apr 5, 2023
frehner
reviewed
Apr 6, 2023
Co-authored-by: Anthony Frehner <frehner@users.noreply.github.com>
frehner
approved these changes
Apr 7, 2023
|
I think we're good to merge. If we keep waiting we'll create more conflicts with other CLI related PRs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #397
This PR updates the CLI to use
@shopify/cli-kit@3.45.0, which brings prompts backed by React 18. We could not do this earlier because the React version of the CLI had conflicts with the React installed in-app, but they are now compatible.馃帺 : Just play with all the CLI commands, especially
initsince that's the one using different prompts.Let's wait to merge this until3.45.0is released as stable (right now we are on-pre.5).