Update Layout.tsx title #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just signed CLA |
|
Thanks, do you mind generating a changeset for this as well? |
frehner
approved these changes
Apr 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Previously the line-height was quite large causing issues with store titles that were long
Before
After
WHAT is this pull request doing?
this PR removes the line-height from a title as titles generally should have a minimal line-height if any (other than the font-size itself)
HOW to test your changes?
Create a store with a long store name
Post-merge steps
Checklist
Notes
I wasn't sure if this PR warrented a changeset, if you feel its needed, happy to create one :)