Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release instructions to the contributing guidelines #791

Closed
wants to merge 2 commits into from

Conversation

lordofthecactus
Copy link
Contributor

Not completely the same are react-hydrogen since now we are in a mono-repo. Here are the guidelines for releasing.

@lordofthecactus lordofthecactus requested a review from a team April 14, 2023 16:58
To update `@shopify/hydrogen` to new calversion, for example from `2023-01` to `2023-04` follow these steps:

- Create a new branch for the version from the latest, e.g. `2023-04`.
- Create a new changeset file updating to `major` any packages that you want released. Add any notes and guides to important updates for devs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is going to work; changesets is going to see major and bump your version from 2023.4.0 to 2024.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm correct me if I’m wrong, but changesets -> creates a PR with package.json versions updated to major 2024.1. If we then update the PR with the versions 2023.4 and merge. Then changesets will see this and publish those versions. Regardless of what we put in the changeset files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great idea, that does sound like it would work. Would just need to be sure to change not only the package.json, but also the markdown files/changelog and stuff like that.

@frehner
Copy link
Contributor

frehner commented Apr 26, 2023

Should we merge this in, and update it as we go? Or make it a part of #815 ?

@wizardlyhel
Copy link
Contributor

outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants