Update links to docs after successful project creation via CLI #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
frehner
approved these changes
Apr 21, 2023
| @@ -234,7 +234,9 @@ export async function runInit( | |||
| )} to start your local development server and start building`.value, | |||
| ].filter((step): step is string => Boolean(step)), | |||
| reference: [ | |||
| 'Building with Hydrogen: https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development', | |||
| 'Getting started with Hydrogen: https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development', | |||
| 'Hydrogen project structure: https://shopify.dev/docs/custom-storefronts/hydrogen/project-structure', | |||
There was a problem hiding this comment.
This one doesn't show up in your screenshot; does it get filtered out, or is the screenshot outdated?
There was a problem hiding this comment.
Ah, good catch. I've updated the screenshot now!
There was a problem hiding this comment.
Ah nice thanks. Looks great! 🚢
There was a problem hiding this comment.
Added a changeset too 👍🏻
|
Oh does this need a changeset? Probably I would think? @gfscott |
|
🚢 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #524
This PR adds a couple more links to documentation when scaffolding out a new project via CLI.
Checklist
[ ] I've added a changeset if this PR contains user-facing or noteworthy changes[ ] I've added tests to cover my changes[ ] I've added or updated the documentation