Fix TypeScript types for flattenConnection #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frehner
commented
May 25, 2023
| if (!edge?.node) { | ||
| throw new Error( | ||
| 'flattenConnection(): Connection edges must contain nodes', | ||
| ); | ||
| } | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access |
There was a problem hiding this comment.
Should have realized something was wrong here. Glad it's fixed these errors though.
blittle
approved these changes
May 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Apparently I've had the TS types for
edgeswrong for a while. Whoops. This also fixes issues that were raised in #937Updated the docs, and apparently we never did
build-docsafter updating the static page. Whoops again.WHAT is this pull request doing?
Checklist