Add a /admin route that redirects to the online store admin page
#989
Conversation
| response = new Response('Not Found', {status: 404}), | ||
| } = options; | ||
|
|
||
| const {pathname, search} = new URL(request.url); | ||
| const redirectFrom = pathname + search; | ||
|
|
||
| if (pathname === '/admin' && !noAdminRedirect) { | ||
| const match = /https:\/\/([^.]+)\.myshopify\.com/g.exec( |
There was a problem hiding this comment.
I assume here that the shop name cannot have a . in it. But if for some reason the regex doesn't match, instead it redirects to https://hydrogen-preview.myshopify.com/admin which does another redirect to https://admin.shopify.com/store/hydrogen-preview.
There was a problem hiding this comment.
That's correct, it can't have a . — and yes, that's the right behaviour. Down the road, we could redirect you directly to https://admin.shopify.com/store/${storename} — but that URL isn't rolled out yet to everyone. In a couple months we can make that change.
There was a problem hiding this comment.
Oh, I didn't realize that URL isn't yet available to everyone. I'll change it to use https://hydrogen-preview.myshopify.com/admin instead.
WHY are these changes introduced?
Add a
/adminroute that redirects to the Shopify admin. This redirect can be disabled by passingnoAdminRedirect: truetostorefrontRedirect:Resolves #988
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist