Fixes Current File Panel report of not found keys #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishrempel
changed the base branch from
kos/all_commits
to
release/i18next-shopify
Derived keys (e.g., such as plurals) are being miscategorised as not found in the Current File Panel report. This commit checks if any existing key paths match derived keys paths, and if so, includes them in the list of in use key paths and removed from the "not found" list. Fixes lokalise#959
trishrempel
force-pushed
the
kos/fix_current_file_panel_key_report_derived_keys
branch
from
f7b4e03
to
fea362f
Compare
trishrempel
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived keys (e.g., such as plurals) are being miscategorized as "not found" in the Current File Panel report. This commit checks if any existing key paths match derived keys paths, and if so, includes them in the list of "in use" key paths and removed from the "not found" list for the file currently loaded.
Fixes lokalise#959