Update CHANGELOG #48
Update CHANGELOG #48
Conversation
CHANGELOG.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased] | |||
| [//]: # '## [Unreleased]' | |||
There was a problem hiding this comment.
I thought we generally did the following for all our readmes. At least that's what I've noticed.
<!--## [Unreleased] -->
There was a problem hiding this comment.
🤷♂️ I was just reverting to what it was before.
I definitely prefer the <!-- syntax to the archaic [//]: #.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@shopify/javascript-utilities", | |||
| "version": "2.3.0", | |||
| "version": "2.4.0", | |||
There was a problem hiding this comment.
We've had minor issues in the past with bumping the version from a PR. Why? When you tag from a branch, the git sha associated with the tag points to a sha in a PR branch. Shipit needs the tag being shipped to point the git sha at the HEAD of master.
I recommending doing this this straight on master after this changelog PR is merged via yarn version --new-version minor
rexmac
force-pushed
the
release-prep-v2.4.0
branch
from
2634319
to
e4826f0
Compare
|
@ismail-syed I've reverted the version bump and will bump and tag using |
|
🎉 |
Prep for v2.4.0 release