Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Paginate using hasNextPage #314

Merged
merged 2 commits into from
Mar 9, 2017
Merged

[FIX] Paginate using hasNextPage #314

merged 2 commits into from
Mar 9, 2017

Conversation

jzjiang
Copy link
Contributor

@jzjiang jzjiang commented Mar 9, 2017

Update to #300 - we use the hasNextPage property on each node to paginate instead of querying until an empty list.

@jzjiang jzjiang requested a review from minasmart March 9, 2017 19:13
@minasmart
Copy link
Contributor

looks like this is missing a yarn.lock update, otherwise 👍

@jzjiang jzjiang merged commit 0923f8d into refactor-to-graphql Mar 9, 2017
@jzjiang jzjiang deleted the fix/pagination branch March 9, 2017 19:28
@doublerebel doublerebel mentioned this pull request Jul 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minasmart minasmart minasmart approved these changes

Assignees
No one assigned
Labels
GraphQL v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzjiang @minasmart