Fix requires_endpoints? condition

Shopify · Dec 18, 2017 · 066138b · 066138b
1 parent 7fb623b
commit 066138b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/kubernetes-deploy/kubernetes_resource/service.rb b/lib/kubernetes-deploy/kubernetes_resource/service.rb
@@ -48,7 +48,12 @@ def exposes_zero_replica_deployment?
     end
 
     def requires_endpoints?
-      return false if external_name_svc? || @related_deployment_replicas.blank?
+      # Service of type External don't have endpoints
+      return false if external_name_svc?
+
+      # problem counting replicas - by default, assume endpoints are required
+      return true if @related_deployment_replicas.blank?
+
       @related_deployment_replicas > 0
     end