Simplify getters

Shopify · Oct 27, 2017 · 2627ec1 · 2627ec1
1 parent 2c27c5e
commit 2627ec1
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/lib/kubernetes-deploy/discoverable_resource.rb b/lib/kubernetes-deploy/discoverable_resource.rb
@@ -10,6 +10,7 @@ class DiscoverableResource < KubernetesResource
 
     class << self
       attr_accessor :version, :group, :type
+      attr_reader :timeout
     end
 
     STATUS_FIELD_ANNOTATION = 'kubernetes-deploy.shopify.io/status-field'
@@ -31,18 +32,11 @@ def self.child_classes
     end
 
     def self.prunable?
-      return @prunable if defined?(@prunable)
-      false
+      @prunable
     end
 
     def self.predeploy?
-      return @predeploy if defined?(@predeploy)
-      false
-    end
-
-    def self.timeout
-      return @timeout if defined?(@timeout)
-      super
+      @predeploy
     end
 
     def self.identity