PR feedback

Shopify · Aug 29, 2019 · 74a8d62 · 74a8d62
1 parent e79a6ac
commit 74a8d62
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/kubernetes-deploy/task_config_validator.rb b/lib/kubernetes-deploy/task_config_validator.rb
@@ -5,8 +5,8 @@ class TaskConfigValidator
       validate_kubeconfig
       validate_context_exists_in_kubeconfig
       validate_context_reachable
-      validate_namespace_exists
       validate_server_version
+      validate_namespace_exists
     ).freeze
 
     delegate :context, :namespace, :logger, to: :@task_config

diff --git a/test/integration/task_config_validator_test.rb b/test/integration/task_config_validator_test.rb
@@ -7,8 +7,7 @@ def test_valid_configuration
   end
 
   def test_only_is_respected
-    validator = KubernetesDeploy::TaskConfigValidator.new(task_config, nil, nil, only: [])
-    assert_predicate(validator, :valid?)
+    assert_predicate(validator(only: []), :valid?)
   end
 
   def test_invalid_kubeconfig