avoid nilref error possibility in OptionsHelper#default_template_dir

Shopify · Jul 26, 2019 · 78b72bd · 78b72bd
1 parent 0b23eaf
commit 78b72bd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/kubernetes-deploy/options_helper.rb b/lib/kubernetes-deploy/options_helper.rb
@@ -35,8 +35,8 @@ def with_validated_template_dirs(template_dirs)
       private
 
       def default_template_dir
-        if ENV.key?("ENVIRONMENT")
-          template_dir = File.join("config", "deploy", ENV['ENVIRONMENT'])
+        template_dir = if ENV.key?("ENVIRONMENT")
+          File.join("config", "deploy", ENV['ENVIRONMENT'])
         end
 
         if !template_dir || template_dir.empty?