Address PR feedback

Shopify · Sep 18, 2019 · a4a0dae · a4a0dae
1 parent 3c0d941
commit a4a0dae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/lib/kubernetes-deploy/runner_task.rb b/lib/kubernetes-deploy/runner_task.rb
@@ -113,9 +113,8 @@ def record_status_once(pod)
     end
 
     def verify_config!(task_template, args)
-      task_config_validator = RunnerTaskConfigValidator.new(@task_config, kubectl, kubeclient_builder)
-      task_config_validator.template = task_template
-      task_config_validator.args = args
+      task_config_validator = RunnerTaskConfigValidator.new(task_template, args, @task_config, kubectl,
+        kubeclient_builder)
       unless task_config_validator.valid?
         @logger.summary.add_action("Configuration invalid")
         @logger.summary.add_paragraph([task_config_validator.errors].map { |err| "- #{err}" }.join("\n"))

diff --git a/lib/kubernetes-deploy/runner_task_config_validator.rb b/lib/kubernetes-deploy/runner_task_config_validator.rb
@@ -1,23 +1,23 @@
 # frozen_string_literal: true
 module KubernetesDeploy
   class RunnerTaskConfigValidator < TaskConfigValidator
-    attr_accessor :template, :args
-
-    def initialize(*args)
-      super
+    def initialize(template, args, *arguments)
+      super(*arguments)
+      @template = template
+      @args = args
       @validations += %i(validate_template validate_args)
     end
 
     private
 
     def validate_args
-      if args.blank?
+      if @args.blank?
         @errors << "Args can't be nil"
       end
     end
 
     def validate_template
-      if template.blank?
+      if @template.blank?
         @errors << "Task template name can't be nil"
       end
     end