Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Katrina Verey <katrina.verey@shopify.com>
  • Loading branch information
dturn and KnVerey committed Sep 30, 2019
1 parent fd0cd63 commit a7e39a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/kubernetes-deploy/deploy_task.rb
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,12 @@ def validate_globals(resources)
global_names = FormattedLogger.indent_four(global_names.join("\n"))

if @allow_globals
msg = "The ability for this task to deploy global resources will be removed in the next version:"
msg = "The ability for this task to deploy global resources will be removed in the next version, which will affect the following resources:"
msg += "\n#{global_names}"
@logger.summary.add_paragraph(ColorizedString.new(msg).yellow)
else
@logger.summary.add_paragraph(ColorizedString.new("Global resources:\n#{global_names}").yellow)
raise FatalDeploymentError, "Deploying global resource is not allowed from this command."
raise FatalDeploymentError, "This command is namespaced and cannot be used to deploy global resources."
end
end

Expand Down

0 comments on commit a7e39a0

Please sign in to comment.