Update tests

Shopify · Aug 3, 2023 · dc02c33 · dc02c33
1 parent dcc08bc
commit dc02c33
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/test/unit/krane/kubernetes_resource/stateful_set_test.rb b/test/unit/krane/kubernetes_resource/stateful_set_test.rb
@@ -4,7 +4,7 @@
 class StatefulSetTest < Krane::TestCase
   include ResourceCacheTestHelper
 
-  def test_deploy_succeeded_when_revision_matches_for_rollingupdate_strategy_without_annotation
+  def test_deploy_succeeded_when_revision_matches_for_rollingupdate_strategy
     ss_template = build_ss_template(updateStrategy: "RollingUpdate", rollout: nil)
     ss = build_synced_ss(ss_template: ss_template)
     assert_predicate(ss, :deploy_succeeded?)
@@ -34,19 +34,19 @@ def test_deploy_does_not_succeed_when_replica_counts_do_not_match_for_ondelete_s
     refute_predicate(ss, :deploy_succeeded?)
   end
 
-  def test_deploy_succeeded_when_replica_counts_match_for_rollingupdate_strategy_with_full_annotation
-    ss_template = build_ss_template(updateStrategy: "RollingUpdate", rollout: "full")
+  def test_deploy_succeeded_when_replica_counts_match_for_rollingupdate_strategy
+    ss_template = build_ss_template(updateStrategy: "RollingUpdate", rollout: nil)
     ss = build_synced_ss(ss_template: ss_template)
     assert_predicate(ss, :deploy_succeeded?)
   end
 
-  def test_deploy_does_not_succeed_when_replica_counts_do_not_match_for_rollingupdate_strategy_with_full_annotation
-    ss_template = build_ss_template(status: { "currentReplicas": 1 }, updateStrategy: "RollingUpdate", rollout: "full")
+  def test_deploy_does_not_succeed_when_replica_counts_do_not_match_for_rollingupdate_strategy
+    ss_template = build_ss_template(status: { "currentReplicas": 1 }, updateStrategy: "RollingUpdate", rollout: nil)
     ss = build_synced_ss(ss_template: ss_template)
     refute_predicate(ss, :deploy_succeeded?)
   end
 
-  def test_deploy_failed_ensures_controller_has_observed_deploy
+  def test_deploy_fails_when_current_and_observed_generations_do_not_match
     ss_template = build_ss_template(status: { "observedGeneration": 1 })
     ss = build_synced_ss(ss_template: ss_template)
     refute_predicate(ss, :deploy_succeeded?)