Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Custom Resource Definition support #128

Closed
KnVerey opened this issue Jul 13, 2017 · 1 comment
Closed

Generic Custom Resource Definition support #128

KnVerey opened this issue Jul 13, 2017 · 1 comment
Assignees
Labels
🆕 feature Makes something new possible 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jul 13, 2017

Instead of hardcoding details about what Shopify's TPR controllers are expected to create, we should provide generic support based on a conventional status field. According to @wfarr investigation, such a status field will be easier to implement in the new CustomResourceDefinitions.

  • We'd query the cluster for valid CRD types at the beginning of the deploy, before creating resource instances.
  • CRD instances would be expected to expose status fields from which we can derive their success/failure
    • We should have a convention for this that lines up with the fields/values first-party controllers set
    • We can provide an override mechanism, likely an annotation, for specifying custom fields/values
@KnVerey KnVerey added the 🆕 feature Makes something new possible label Jul 17, 2017
@KnVerey KnVerey added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Jan 9, 2019
@timothysmith0609 timothysmith0609 self-assigned this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 feature Makes something new possible 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229
Projects
None yet
Development

No branches or pull requests

3 participants