Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider treatment of "!exists?" in KubernetesResource classes #347

Open
KnVerey opened this issue Oct 9, 2018 · 0 comments
Open

Reconsider treatment of "!exists?" in KubernetesResource classes #347

KnVerey opened this issue Oct 9, 2018 · 0 comments
Labels
🛠️ sustainability Technical enhancement or debt repayment

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Oct 9, 2018

Currently, this status is set if we get any kind of error from the API server (404 or otherwise) and is assumed to be transient. A more sensible approach might be to explicitly set @exists = false on a 404 and consider the resource to have failed immediately when we see that. If the API server has no record of it after the creation request, it isn't going to spontaneously appear. If that happens because the user deleted the resource immediately out of band, optimistically polling until the timeout seems like the wrong behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ sustainability Technical enhancement or debt repayment
Projects
None yet
Development

No branches or pull requests

1 participant