You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: whoever pointed out the other day that our entrypoint methods still don't all have the same name was correct. RestartTask's methods need to be renamed to run/run! as part of the Krane rename. Before we do the actual release, we should also audit the arguments to make sure they're sensible and consistent (same names for same thing, required vs. optional, on initialize vs on run).
Note: whoever pointed out the other day that our entrypoint methods still don't all have the same name was correct. RestartTask's methods need to be renamed to run/run! as part of the Krane rename.
Before we do the actual release, we should also audit the arguments to make sure they're sensible and consistent (same names for same thing, required vs. optional, on initialize vs on run).
Tracking the audit in #528. But ideally any work that needs to be done to bring our public interfaces into compliance will be done with the issue that adds the new task.
Problem
We're transitioning from kubernetes-deploy to krane. This means we need to remove all references to
kubernetes-deploy
in the code base.This issue excludes annotations which are handled in #526 .
This issue excludes the gemspec which is handled in #528 .
Possible solution
Alternative solutions
Split the documentation updates into its own PR.
Acceptance criteria
Additional context
#256 (comment)
The text was updated successfully, but these errors were encountered: