Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename code references of kubernetes-deploy to krane #527

Closed
dturn opened this issue Aug 14, 2019 · 2 comments · Fixed by #585
Closed

Rename code references of kubernetes-deploy to krane #527

dturn opened this issue Aug 14, 2019 · 2 comments · Fixed by #585
Assignees
Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229

Comments

@dturn
Copy link
Contributor

dturn commented Aug 14, 2019

Problem

We're transitioning from kubernetes-deploy to krane. This means we need to remove all references to kubernetes-deploy in the code base.

This issue excludes annotations which are handled in #526 .
This issue excludes the gemspec which is handled in #528 .

Possible solution

  • Update the docs
  • Update classes & modules

Alternative solutions

Split the documentation updates into its own PR.

Acceptance criteria

  • Results from greping 'kubernetes-deploy' returns only annotations, historical change log entries, and the gemspec, shipit.yml.

Additional context

#256 (comment)

@dturn dturn self-assigned this Aug 14, 2019
@dturn dturn mentioned this issue Aug 14, 2019
8 tasks
@KnVerey
Copy link
Contributor

KnVerey commented Aug 22, 2019

Note: whoever pointed out the other day that our entrypoint methods still don't all have the same name was correct. RestartTask's methods need to be renamed to run/run! as part of the Krane rename. Before we do the actual release, we should also audit the arguments to make sure they're sensible and consistent (same names for same thing, required vs. optional, on initialize vs on run).

@dturn
Copy link
Contributor Author

dturn commented Aug 23, 2019

Note: whoever pointed out the other day that our entrypoint methods still don't all have the same name was correct. RestartTask's methods need to be renamed to run/run! as part of the Krane rename.

Tracking the interface rename in #530

Before we do the actual release, we should also audit the arguments to make sure they're sensible and consistent (same names for same thing, required vs. optional, on initialize vs on run).

Tracking the audit in #528. But ideally any work that needs to be done to bring our public interfaces into compliance will be done with the issue that adds the new task.

@dturn dturn removed their assignment Sep 24, 2019
@dturn dturn added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Sep 25, 2019
@douglas douglas self-assigned this Oct 7, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants