Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krane restart #530

Closed
dturn opened this issue Aug 14, 2019 · 3 comments
Closed

krane restart #530

dturn opened this issue Aug 14, 2019 · 3 comments
Assignees

Comments

@dturn
Copy link
Contributor

dturn commented Aug 14, 2019

Problem

Add the krane restart command, https://docs.google.com/document/d/1oInUsKplYGNWTymPY48xtDCx3x4Cwc-phcEKUkt2v4U/view# has details on flags that need to be supported.

This is blocked by #524.

The actual restart task doesn't match our standard interface convention. Please change perform/perform! to run/run! as well as ensure that new & run use the same conventions as the other tasks, its fine to do this in a separate PR.

Possible solution

Build a thor task that calls RestartTask.new.

Alternative solutions

Depending on the difficulty of supporting --verify-result=false this may need to be split into a second PR. We've discussed adding a new command that can stand alone verify a namespace, if a second PR is required please do it with an eye towards supporting such a command.

Acceptance criteria

  • The command must work with all flags
  • The command should have tests.

Additional context

#256 is the tracking issue for the new CLI.

@dturn dturn self-assigned this Aug 14, 2019
@dturn dturn changed the title krane restart krane restart Aug 14, 2019
@dturn dturn mentioned this issue Aug 14, 2019
@RyanBrushett
Copy link
Contributor

#548

@dturn
Copy link
Contributor Author

dturn commented Sep 16, 2019

The initial pass was added in 548. We still need to support the -f` flag. Thor merged rails/thor#674 (allow repeatable options), but they haven't cut a release, depending on the timeline we may point at a sha.

@dturn
Copy link
Contributor Author

dturn commented Sep 17, 2019

To help us prioritize work I've cut separate issue for adding the -f flag. #558

@dturn dturn closed this as completed Sep 17, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants