Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krane run #531

Closed
dturn opened this issue Aug 14, 2019 · 1 comment
Closed

Krane run #531

dturn opened this issue Aug 14, 2019 · 1 comment
Assignees

Comments

@dturn
Copy link
Contributor

dturn commented Aug 14, 2019

Problem

Add the krane run command, https://docs.google.com/document/d/1oInUsKplYGNWTymPY48xtDCx3x4Cwc-phcEKUkt2v4U/view# has details on flags that need to be supported.

Ensure that new & run use the same conventions as the other tasks, if there is a mismatch that needs to be fixed it can be done in a second PR.

This is blocked by #524.

Possible solution

Build a thor task that calls RunnerTask.new. See #530 for thoughts about --verify-result=false.

Acceptance criteria

  • The command must work with all flags
  • The command should have tests.

Additional context

#256 is the tracking issue for the new CLI.

@dturn dturn self-assigned this Aug 15, 2019
@RyanBrushett RyanBrushett assigned RyanBrushett and unassigned dturn Sep 6, 2019
@RyanBrushett
Copy link
Contributor

I'll cut an issue for -f and try to get time to hack on it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants