Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState #851

Closed
bcha opened this issue Dec 16, 2021 · 6 comments
Closed

uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState #851

bcha opened this issue Dec 16, 2021 · 6 comments

Comments

@bcha
Copy link

bcha commented Dec 16, 2021

Bug report

krane blows up on deploy since last night. Possibly related to Rails 7.0.0 release? See similar: rails/rails#43889

-> Need to require top level active_support in krane too? I'm not too familiar with Ruby or gem myself.

Expected behavior: krane doesnt blow up

Actual behavior: krane blows up

Version(s) affected: Both 2.3.0 & 2.3.4 are affected.

Steps to Reproduce

Run krane deploy:

$ krane deploy ${NAMESPACE} ${KUBE_CONTEXT} -f ./k8s/overlays/${ENVIRONMENT}/kustomized/${ENVIRONMENT}.yml --global-timeout=${KRANE_GLOBAL_TIMEOUT} ${KRANE_EXTRA_ARGS}
/usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:184:in `current_thread_backend': uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState (NameError)
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:103:in `backend='
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:201:in `<module:ActiveSupport>'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:11:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/core_ext/array/conversions.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/duration.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/core_ext/numeric/time.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/common.rb:6:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/deploy_task.rb:8:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/cli/krane.rb:2:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/exe/krane:4:in `<top (required)>'
	from /usr/local/bundle/bin/krane:23:in `load'
	from /usr/local/bundle/bin/krane:23:in `<main>'
@bcha
Copy link
Author

bcha commented Dec 16, 2021

We worked around this issue by explicitly installing older activesupport before krane in our dockerfiles:

...
    gem install activesupport -v 6.1.4.3 && \
    gem install krane:2.3.4

Seems to work fine as a workaround, dunno if there are any fun side-effects.

kblcuk added a commit to SharkPunch/krane-container that referenced this issue Dec 20, 2021
Pinning to v6 activesupport, since v7 causes krane to crash

Shopify/krane#851
kblcuk added a commit to SharkPunch/krane-container that referenced this issue Dec 22, 2021
Pinning to v6 activesupport, since v7 causes krane to crash

Shopify/krane#851
@ibratoev
Copy link

The blew up our updates as well. I consider it a critical issue because it breaks clean installs of krane.

@sonalkr132
Copy link

I just want to voice my support for this. It broke our deployments after update of shipit-engine. krane is not usable with activesupport 7.

@simi
Copy link

simi commented Apr 17, 2022

Isn't #861 fixing this?

@benlangfeld
Copy link
Contributor

@simi Indeed. Y'all just need to upgrade krane. This issue can be closed.

@felipesaezreyes
Copy link

Resolved by #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants