Don't consider pod preempting a failure #317
Conversation
| @@ -170,6 +170,21 @@ def test_deploy_failed_is_false_for_evicted | |||
| assert_nil pod.failure_message | |||
| end | |||
|
|
|||
| def test_deploy_failed_is_false_for_preempting | |||
| container_state = pod_spec.merge( | |||
| "status" => { | |||
There was a problem hiding this comment.
Are you confident that this is what the status will look like (or at least the reason). Otherwise this PR wont work.
There was a problem hiding this comment.
| @@ -170,6 +170,21 @@ def test_deploy_failed_is_false_for_evicted | |||
| assert_nil pod.failure_message | |||
| end | |||
|
|
|||
| def test_deploy_failed_is_false_for_preempting | |||
| container_state = pod_spec.merge( | |||
| "status" => { | |||
There was a problem hiding this comment.
DazWorrall
force-pushed
the
improve-preemption-handling
branch
from
a2e6130
to
ab83055
Compare
|
When I run into this case it looks like |
I suspect that kubernetes thinks progress is being made, progress to the controller is defined rather broadly, so it never actually hits |
Similar to #293, pod/node preempting is a recoverable state (the desired pod count will reduce once the node has been reaped), so isn't a valid condition for fast failure.